New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(artifacts): add new_draft method to modify and log saved artifacts as new version #5524
Conversation
8ca2003
to
d0ee0c6
Compare
d0ee0c6
to
1a44cde
Compare
How do you feel about making this a method on the artifact being cloned? I.e. |
I had it that way at first, and then changed it.
I don't feel very strongly about this though, I can change it back. What do you think? |
Also no strong opinions. I favor the more concise version. Is there a better name than I'm happy with whatever you decide you want to go with, I just wanted to bring up the question and make it an explicit decision. |
I thought about Alright, I'll change to |
1a44cde
to
ab57ec6
Compare
…logged as a new version
5a298aa
to
00fe3c7
Compare
/fix-title |
Fixes WB-12549
Description
Added the ability to create a new draft artifact bootstrapped with an existing artifact.
Note on API design:
I decided to create a new
Artifact
instance instead of modifying an existing instance. Changing the identity of an existing instance would be error prone. Note that we keep references toArtifact
instances in various places (e.g. here and here) and assume their identity doesn't change over time.Test plan