Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): add support for propagating messages from the internal process #5803

Merged
merged 17 commits into from
Sep 5, 2023

Conversation

kptkin
Copy link
Contributor

@kptkin kptkin commented Jun 28, 2023

Fixes

Description

What does the PR do?

TODO:

  • Add implicit finish code path
  • Add static print function for the warnings...

馃 Generated by Copilot at 78cffb7

No summary available (Limit exceeded: required to process 78627 tokens, but only 50000 are allowed per call)

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

copilot:poem

@github-actions github-actions bot added cc-fix and removed cc-fix labels Jun 28, 2023
@kptkin kptkin added this to the sdk-2023-07.1 milestone Jun 28, 2023
@github-actions github-actions bot added cc-fix and removed cc-fix labels Jun 28, 2023
@github-actions github-actions bot added cc-fix and removed cc-fix labels Jun 28, 2023
wandb/sdk/internal/handler.py Outdated Show resolved Hide resolved
@kptkin kptkin modified the milestones: sdk-2023-07.1, sdk-2023-08.1 Jun 30, 2023
@github-actions github-actions bot added cc-fix and removed cc-fix labels Jul 6, 2023
@kptkin kptkin requested a review from raubitsj July 25, 2023 17:29
@github-actions github-actions bot added cc-fix and removed cc-fix labels Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #5803 (b948e41) into main (738a9ac) will decrease coverage by 0.07%.
Report is 36 commits behind head on main.
The diff coverage is 94.23%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5803      +/-   ##
==========================================
- Coverage   78.02%   77.95%   -0.07%     
==========================================
  Files         379      379              
  Lines       43559    43610      +51     
==========================================
+ Hits        33985    33996      +11     
- Misses       9522     9562      +40     
  Partials       52       52              
Flag Coverage 螖
unittest 81.56% <96.07%> (-0.08%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage 螖
nexus/pkg/server/handler.go 0.00% <0.00%> (酶)
wandb/sdk/wandb_run.py 91.21% <93.54%> (+0.04%) 猬嗭笍
wandb/sdk/interface/interface.py 91.43% <100.00%> (+0.05%) 猬嗭笍
wandb/sdk/interface/interface_shared.py 84.28% <100.00%> (+0.18%) 猬嗭笍
wandb/sdk/internal/handler.py 94.62% <100.00%> (+0.06%) 猬嗭笍
wandb/sdk/service/streams.py 92.12% <100.00%> (+0.10%) 猬嗭笍

... and 11 files with indirect coverage changes

@kptkin kptkin marked this pull request as ready for review August 24, 2023 06:10
@github-actions github-actions bot added cc-fix and removed cc-fix labels Aug 24, 2023
@kptkin kptkin requested a review from dmitryduev August 24, 2023 06:13
@github-actions github-actions bot added cc-fix and removed cc-fix labels Aug 24, 2023
@dmitryduev dmitryduev merged commit 3e9a3e7 into main Sep 5, 2023
68 of 70 checks passed
@dmitryduev dmitryduev deleted the print-drop-step branch September 5, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants