-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(launch): launch cli command should exit with non-zero status if underlying launched run exits with non-zero status #6078
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6078 +/- ##
==========================================
- Coverage 78.09% 78.02% -0.07%
==========================================
Files 380 380
Lines 44314 44317 +3
==========================================
- Hits 34607 34579 -28
- Misses 9655 9686 +31
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…zero-if-launched-run-exits-non-zero
those are legitimate test failures: https://app.circleci.com/pipelines/github/wandb/wandb/25629/workflows/7bc633b3-1f63-43ec-bc0f-493bb87522f4/jobs/724360 it appears that in at least one case the return value of |
…zero-if-launched-run-exits-non-zero
…zero-if-launched-run-exits-non-zero
…zero-if-launched-run-exits-non-zero
…zero-if-launched-run-exits-non-zero
…zero-if-launched-run-exits-non-zero
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, had to do the same thing when using the job_tracker object in a launch agent test. Specifically in test_agent.py
with this line:
run.get_status.return_value.state = "failed"
Fixes
Description
What does the PR do?
🤖 Generated by Copilot at 7cd714d
Added a new option and a status check for the
launch
command inwandb/cli/cli.py
. This allows users to run launched runs asynchronously or synchronously and see their status.Testing
How was this PR tested?
Checklist
🤖 Generated by Copilot at 7cd714d