-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(launch): Default log_code exclusion behavior now correctly handles wandb
in the root path prefix.
#6095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickpenaranda
changed the title
fix(artifacts): log_code works correctly in directories that contain 'wandb'
fix(launch): log_code works correctly in directories that contain 'wandb'
Aug 17, 2023
nickpenaranda
commented
Aug 17, 2023
nickpenaranda
commented
Aug 17, 2023
nickpenaranda
commented
Aug 17, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6095 +/- ##
==========================================
- Coverage 78.11% 78.02% -0.09%
==========================================
Files 380 380
Lines 44236 44241 +5
==========================================
- Hits 34555 34521 -34
- Misses 9631 9670 +39
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kptkin
reviewed
Aug 17, 2023
kptkin
reviewed
Aug 17, 2023
kptkin
approved these changes
Aug 18, 2023
nickpenaranda
changed the title
fix(launch): log_code works correctly in directories that contain 'wandb'
fix(launch): Default log_code exclusion behavior now correctly handles Aug 18, 2023
wandb
in the root path prefix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Description
What does the PR do?
🤖 Generated by Copilot at e4fef90
This pull request improves the file filtering and logging functionality in the
wandb/sdk/lib
andwandb/sdk
modules, and adds unit tests for thefilenames.py
module. It allows users to customize the file inclusion and exclusion criteria for logging source code to the W&B dashboard, and makes the file filtering logic more robust and flexible.More specifically, this addresses an issue that prevents
log_code
from behaving as expected when the absolute path to the root directory containswandb
or.wandb
. This PR...log_code
to allow callers to pass either 1- or 2-parameter callables forinclude_fn
and/orexclude_fn
, where the 1st argument is the absolute file path, and the 2nd argument is the absolute root pathexclude_fn
to exclude only<root>/.wandb/*
and<root>/wandb/*
as originally intended, and NOT all paths that contain.wandb
orwandb
anywhere.Testing
How was this PR tested? New unit test suite
Checklist
🤖 Generated by Copilot at e4fef90