Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nexus): fix race condition for defer and update control #6125

Merged
merged 4 commits into from
Aug 22, 2023
Merged

Conversation

kptkin
Copy link
Contributor

@kptkin kptkin commented Aug 22, 2023

Description

What does the PR do?

This PR fixes a race condition in the defer state machine and fixes the control values for the records in the stream.

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

馃 Generated by Copilot at 2a54285

The nexus package had a flaw
It used cgo to call nvml raw
But they refactored the code
And removed that heavy load
Now the system monitor is more au

@kptkin kptkin changed the title Revert "feat(nexus): add Nvidia GPU asset to system monitor (#6081)" fix(nexus): race condition + control Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #6125 (6d674f3) into main (ad888f5) will decrease coverage by 0.16%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6125      +/-   ##
==========================================
- Coverage   78.12%   77.96%   -0.16%     
==========================================
  Files         380      380              
  Lines       44267    44301      +34     
==========================================
- Hits        34582    34540      -42     
- Misses       9635     9711      +76     
  Partials       50       50              
Flag Coverage 螖
unittest 81.51% <酶> (-0.11%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage 螖
nexus/pkg/server/handler.go 0.00% <0.00%> (酶)
nexus/pkg/server/writer.go 0.00% <0.00%> (酶)

... and 15 files with indirect coverage changes

@github-actions github-actions bot added cc-fix and removed cc-fix labels Aug 22, 2023
@kptkin kptkin changed the title fix(nexus): race condition + control fix(nexus): fix race condition for defer and update control Aug 22, 2023
@kptkin kptkin marked this pull request as ready for review August 22, 2023 03:41
@github-actions github-actions bot added cc-fix and removed cc-fix labels Aug 22, 2023
@kptkin kptkin requested a review from dmitryduev August 22, 2023 03:43
@github-actions github-actions bot added cc-fix and removed cc-fix labels Aug 22, 2023
@kptkin kptkin merged commit 71b0a15 into main Aug 22, 2023
76 of 79 checks passed
@kptkin kptkin deleted the fix-race-1 branch August 22, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants