fix(sdk): update report id validation and encoding #6203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6203 +/- ##
==========================================
- Coverage 77.83% 77.74% -0.10%
==========================================
Files 379 379
Lines 43763 43772 +9
==========================================
- Hits 34062 34029 -33
- Misses 9648 9690 +42
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jo-fang
force-pushed
the
joyce/report-from-url
branch
from
29b8da7
to
7de7059
Compare
jlzhao27
reviewed
Aug 31, 2023
jo-fang
force-pushed
the
joyce/report-from-url
branch
from
735a2f2
to
0b4af0c
Compare
jo-fang
force-pushed
the
joyce/report-from-url
branch
from
0b4af0c
to
e1de0e3
Compare
jlzhao27
approved these changes
Sep 1, 2023
jo-fang
changed the title
= back into report id = padding back into report id
|
/fix-title |
github-actions
bot
changed the title
= padding back into report id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Description
What does the PR do?
馃 Generated by Copilot at acafbd1
Add validation and normalization for
report_idparameter ofReportclass. Fix decoding issues caused by missing '=' character in report url.Testing
How was this PR tested?
Checklist
馃 Generated by Copilot at acafbd1