-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(artifacts): prototype for models api #6205
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6205 +/- ##
==========================================
+ Coverage 77.03% 77.10% +0.06%
==========================================
Files 387 387
Lines 45015 45047 +32
==========================================
+ Hits 34679 34732 +53
+ Misses 10283 10262 -21
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tests/pytest_tests/system_tests/test_core/test_model_workflow.py
Outdated
Show resolved
Hide resolved
tests/pytest_tests/system_tests/test_core/test_model_workflow.py
Outdated
Show resolved
Hide resolved
tests/pytest_tests/system_tests/test_core/test_model_workflow.py
Outdated
Show resolved
Hide resolved
tests/pytest_tests/system_tests/test_core/test_model_workflow.py
Outdated
Show resolved
Hide resolved
tests/pytest_tests/system_tests/test_core/test_model_workflow.py
Outdated
Show resolved
Hide resolved
Hey @ibindlish - who are we still waiting on a review on here? Oops - I see you are resolving a comment :) ignore me! |
@noaleetz just trying to get this comment resolved: #6205 (comment) |
Note to self - will be released with next SDK release - release version: sdk-0.11.1 |
Fixes
Description
Prototype for model APIs:
log_model()
(note:max_objects
param while adding reference is not exposed on log_artifact, hence not exposed for log_model)use_model()
- returns path to directory where we download the artifact files. If there's only 1 file, then we return the path to that file.link_model()
Re. Notion doc
🤖 Generated by Copilot at 78991d8
Add new functions to
wandb/apis/models.py
for logging, using, and linking model artifacts. These functions simplify the workflow of working with model artifacts in wandb.Testing
max_objects=10**10
in wandb _log_artifact() for testing purposes; but from a user pov, till we set the default for max_objects asNone
they won't be able to log large artifact references)Checklist
🤖 Generated by Copilot at 78991d8