Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): add setting to disable automatic machine info capture #6230

Merged
merged 3 commits into from
Sep 5, 2023

Conversation

kptkin
Copy link
Contributor

@kptkin kptkin commented Sep 5, 2023

Fixes

  • Fixes WB-NNNNN
  • Fixes #NNNN

Description

To turn off automatic machine info capture:

run = wandb.init(settings=wandb.Settings(_disable_machine_info=True))

馃 Generated by Copilot at fb45754

No summary available (Limit exceeded: required to process 61363 tokens, but only 50000 are allowed per call)

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

copilot:poem

@github-actions github-actions bot added cc-feat and removed cc-feat labels Sep 5, 2023
@kptkin kptkin added this to the sdk-2023-09.1 milestone Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #6230 (b297728) into main (7da1dfa) will decrease coverage by 0.09%.
The diff coverage is 66.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6230      +/-   ##
==========================================
- Coverage   77.26%   77.17%   -0.09%     
==========================================
  Files         384      384              
  Lines       44130    44133       +3     
==========================================
- Hits        34095    34061      -34     
- Misses       9982    10019      +37     
  Partials       53       53              
Flag Coverage 螖
unittest 80.72% <66.66%> (-0.09%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage 螖
wandb/sdk/lib/_settings_toposort_generated.py 100.00% <酶> (酶)
wandb/sdk/wandb_init.py 86.68% <50.00%> (-0.30%) 猬囷笍
wandb/sdk/wandb_settings.py 92.38% <100.00%> (-0.45%) 猬囷笍

... and 18 files with indirect coverage changes

@dmitryduev dmitryduev changed the title feat(sdk): add setting to disable all mahince info feat(sdk): add setting to disable capturing of machine info Sep 5, 2023
@dmitryduev
Copy link
Member

/fix-title

@github-actions github-actions bot added cc-feat and removed cc-feat labels Sep 5, 2023
@dmitryduev dmitryduev marked this pull request as ready for review September 5, 2023 23:38
@dmitryduev dmitryduev requested a review from a team September 5, 2023 23:38
Copy link
Member

@dmitryduev dmitryduev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;) :patrick-hammer:

@dmitryduev dmitryduev changed the title feat(sdk): add setting to disable capturing of machine info feat(sdk): add setting to to disable automatic machine Info capture Sep 5, 2023
@github-actions github-actions bot added cc-feat and removed cc-feat labels Sep 5, 2023
@dmitryduev dmitryduev changed the title feat(sdk): add setting to to disable automatic machine Info capture feat(sdk): add setting to to disable automatic machine info capture Sep 5, 2023
@github-actions github-actions bot added cc-feat and removed cc-feat labels Sep 5, 2023
@dmitryduev dmitryduev merged commit 71200a7 into main Sep 5, 2023
78 of 80 checks passed
@dmitryduev dmitryduev deleted the disable-machine-info branch September 5, 2023 23:48
@dmitryduev dmitryduev changed the title feat(sdk): add setting to to disable automatic machine info capture feat(sdk): add setting to disable automatic machine info capture Sep 6, 2023
@github-actions github-actions bot added cc-feat and removed cc-feat labels Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants