Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nexus): add support for policy=end in wandb.save #6267

Merged
merged 8 commits into from
Sep 9, 2023
Merged

Conversation

kptkin
Copy link
Contributor

@kptkin kptkin commented Sep 8, 2023

Fixes

  • Fixes WB-NNNNN
  • Fixes #NNNN

Description

What does the PR do?

馃 Generated by Copilot at 094b530

Add caching for files with END or LIVE policy in handler.go. This improves the efficiency and consistency of file handling on the server.

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

馃 Generated by Copilot at f35fe91

Sing, O Muse, of the cunning Handler, who tracked the files
That he sent to the cloud with swift and varied policies,
And when his task was done, he sent a final message clear
To tell the mighty backend all the deeds that he had wrought.

nexus/pkg/server/handler.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added cc-feat and removed cc-feat labels Sep 8, 2023
@dmitryduev dmitryduev requested a review from a team September 8, 2023 21:45
@dmitryduev dmitryduev marked this pull request as ready for review September 8, 2023 21:45
@github-actions github-actions bot added cc-feat and removed cc-feat labels Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #6267 (fe1a6d8) into main (0f45a1e) will decrease coverage by 0.18%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6267      +/-   ##
==========================================
- Coverage   77.17%   76.99%   -0.18%     
==========================================
  Files         384      385       +1     
  Lines       44301    44352      +51     
==========================================
- Hits        34189    34150      -39     
- Misses      10059    10149      +90     
  Partials       53       53              
Flag Coverage 螖
unittest 80.74% <酶> (-0.10%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage 螖
nexus/pkg/server/files.go 0.00% <0.00%> (酶)
nexus/pkg/server/handler.go 0.00% <0.00%> (酶)

... and 11 files with indirect coverage changes

@kptkin kptkin merged commit 5eeb949 into main Sep 9, 2023
76 of 77 checks passed
@kptkin kptkin deleted the save-policy-end branch September 9, 2023 01:28
@kptkin kptkin added this to the sdk-2023-09.2 milestone Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants