fix(launch): fail rqis if no run is created

[bcsherma]

Fixes

• Fixes WB-15598

Description

This PR makes the agent fail RQIs when a wandb run is not created even if the job executes successfully on the target system.

We will add a regression test for this: https://wandb.atlassian.net/browse/WB-15604

Copilot

🤖 Generated by Copilot at f230a14

Summary

🚀🧹🔧

Improved the usability and reliability of wandb.launch by removing unnecessary code and enhancing error and log messages in agent.py.

Sing, O Muse, of the valiant coder who refined the launch agent
And removed the false and needless lines that marred the splendid feature
He made the errors and the logs more clear and helpful to the user
Like Hermes, swift and cunning, he enhanced the wandb launcher

Walkthrough

• Remove redundant and misleading code that checked for job_and_run_status.completed_status == "success" (link)
• Improve error message when submitted job fails to call wandb.init by distinguishing between exit statuses and clarifying terminology (link)
• Fix typo and clarify log message when thread has no run by specifying that no job or run was associated with the thread (link)

[codecov]

Codecov Report

Merging #6324 (ef9c987) into main (75fa619) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6324      +/-   ##
==========================================
- Coverage   77.18%   77.14%   -0.05%     
==========================================
  Files         387      387              
  Lines       44421    44430       +9     
==========================================
- Hits        34288    34276      -12     
- Misses      10080    10101      +21     
  Partials       53       53              

Flag	Coverage Δ
unittest	80.90% <100.00%> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
wandb/sdk/launch/agent/agent.py	78.53% <100.00%> (+4.53%)	⬆️

... and 14 files with indirect coverage changes

[KyleGoyette]

Approved with 2 comments, please handle them before merging