Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nexus): implement config debouncing mechanism #6331

Merged
merged 15 commits into from
Sep 26, 2023
Merged

Conversation

kptkin
Copy link
Contributor

@kptkin kptkin commented Sep 20, 2023

Fixes

  • Fixes WB-NNNNN
  • Fixes #NNNN

Description

What does the PR do?

🤖 Generated by Copilot at d8b02e1

This pull request adds config debouncing logic to the nexus sender package, which reduces the server load and improves the performance of the metric feature. It uses a new Debouncer type defined in nexus/internal/debounce/debounce.go and a dependency on the golang.org/x/time package. It also updates some system tests to be compatible with the new logic.

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

🤖 Generated by Copilot at d8b02e1

To reduce the config update load
The sender now uses a Debouncer mode
It wraps a rate limiter
And drops the jitter
But ensures the last trigger is showed

@github-actions github-actions bot added cc-feat and removed cc-feat labels Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #6331 (d8b02e1) into main (43b2598) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6331      +/-   ##
==========================================
- Coverage   77.27%   77.15%   -0.13%     
==========================================
  Files         387      387              
  Lines       44462    44470       +8     
==========================================
- Hits        34359    34310      -49     
- Misses      10050    10107      +57     
  Partials       53       53              
Flag Coverage Δ
unittest 80.94% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
nexus/pkg/server/sender.go 16.98% <0.00%> (-0.24%) ⬇️

... and 15 files with indirect coverage changes

@dmitryduev dmitryduev marked this pull request as ready for review September 26, 2023 20:28
@dmitryduev dmitryduev requested a review from a team as a code owner September 26, 2023 20:28
@dmitryduev
Copy link
Member

/fix-title

@github-actions github-actions bot added cc-feat and removed cc-feat labels Sep 26, 2023
Copy link
Member

@dmitryduev dmitryduev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@github-actions github-actions bot changed the title feat(nexus): support debouncing of config/summary... feat(nexus): implement config debouncing mechanism Sep 26, 2023
@github-actions github-actions bot added cc-feat and removed cc-feat labels Sep 26, 2023
nexus/pkg/server/sender.go Outdated Show resolved Hide resolved
Co-authored-by: Katia Patkin <87335417+kptkin@users.noreply.github.com>
@dmitryduev dmitryduev merged commit d982942 into main Sep 26, 2023
33 of 68 checks passed
@dmitryduev dmitryduev deleted the nexus-debouncer branch September 26, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants