-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(artifacts): Allow adding s3 bucket as reference artifact #6346
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6346 +/- ##
==========================================
- Coverage 77.24% 77.16% -0.09%
==========================================
Files 387 387
Lines 44436 44441 +5
==========================================
- Hits 34323 34291 -32
- Misses 10060 10097 +37
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're in a hurry this can merge as-is, but if we have some more hours I'd like to take this opportunity to clean up the function (which was a little ugly before you got to it)
Let's make this a follow up, I think we are under time pressure here. |
newline=False, | ||
) | ||
objs = self._s3.Bucket(bucket).objects.filter(Prefix=key).limit(max_objects) | ||
if key != "": | ||
objs = objs = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo, extra objs =
Fixes
Description
Allows
If the bucket is empty then an empty artifact sequence (i.e., no versions) is created.
馃 Generated by Copilot at 2ba269f
This pull request enhances the
S3Handler
class to support empty keys as bucket artifacts and optimize the bucket operations. It modifies theload_path
andstore_path
functions ins3_handler.py
to implement these changes.Testing
Upload
https://wandb.ai/ibindlish/test-s3/artifacts/data/ref-artifact/v2/overview
Download
Checklist
馃 Generated by Copilot at 2ba269f