-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nexus): add sync file counts in the footer #6371
Merged
Merged
+135
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6371 +/- ##
==========================================
+ Coverage 76.25% 77.00% +0.75%
==========================================
Files 387 387
Lines 44612 44642 +30
==========================================
+ Hits 34017 34375 +358
+ Misses 10542 10214 -328
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…to nexus-file-counts
kptkin
reviewed
Oct 9, 2023
Comment on lines
179
to
184
// um.fileCounts = &service.FileCounts{ | ||
// WandbCount: 42, | ||
// MediaCount: 420, | ||
// ArtifactCount: -1, | ||
// OtherCount: 100500, | ||
// } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
// um.fileCounts = &service.FileCounts{ | |
// WandbCount: 42, | |
// MediaCount: 420, | |
// ArtifactCount: -1, | |
// OtherCount: 100500, | |
// } |
kptkin
reviewed
Oct 9, 2023
dmitryduev
commented
Oct 9, 2023
kptkin
approved these changes
Oct 9, 2023
…to nexus-file-counts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does the PR do?
🤖 Generated by Copilot at ef24ea9
This pull request adds file type counting and handling to the nexus uploader and server, improves the closing logic of the nexus handler, sender, and writer types, and fixes some minor issues in the nexus and wandb code and documentation. It also updates the nexus artifact saver to use the ArtifactFile type.
Testing
How was this PR tested?
🤖 Generated by Copilot at ef24ea9