Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nexus): add sync file counts in the footer #6371

Merged
merged 14 commits into from
Oct 9, 2023
Merged

Conversation

dmitryduev
Copy link
Member

@dmitryduev dmitryduev commented Sep 27, 2023

Description

What does the PR do?

🤖 Generated by Copilot at ef24ea9

This pull request adds file type counting and handling to the nexus uploader and server, improves the closing logic of the nexus handler, sender, and writer types, and fixes some minor issues in the nexus and wandb code and documentation. It also updates the nexus artifact saver to use the ArtifactFile type.

Testing

How was this PR tested?

🤖 Generated by Copilot at ef24ea9

Sing, O Muse, of the code review that shook the GitHub realm,
How the valiant developers strove to improve their project's helm,
They removed and added, fixed and renamed, with skill and care sublime,
And handled files of various types, closing them in due time.

@github-actions github-actions bot added cc-feat and removed cc-feat labels Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #6371 (9774bd7) into main (2bd173a) will increase coverage by 0.75%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6371      +/-   ##
==========================================
+ Coverage   76.25%   77.00%   +0.75%     
==========================================
  Files         387      387              
  Lines       44612    44642      +30     
==========================================
+ Hits        34017    34375     +358     
+ Misses      10542    10214     -328     
  Partials       53       53              
Flag Coverage Δ
unittest 80.88% <ø> (+0.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
wandb/sdk/internal/sender.py 92.80% <ø> (ø)
nexus/pkg/server/stream.go 0.00% <0.00%> (ø)
nexus/pkg/server/writer.go 0.00% <0.00%> (ø)
nexus/pkg/server/handler.go 0.00% <0.00%> (ø)
nexus/pkg/server/sender.go 16.41% <0.00%> (-0.69%) ⬇️

... and 23 files with indirect coverage changes

@raubitsj raubitsj self-assigned this Sep 29, 2023
@raubitsj raubitsj added this to the sdk-2023-10.1 milestone Sep 29, 2023
@dmitryduev dmitryduev marked this pull request as ready for review October 9, 2023 20:40
@dmitryduev dmitryduev requested a review from a team as a code owner October 9, 2023 20:40
@github-actions github-actions bot added cc-feat and removed cc-feat labels Oct 9, 2023
Comment on lines 179 to 184
// um.fileCounts = &service.FileCounts{
// WandbCount: 42,
// MediaCount: 420,
// ArtifactCount: -1,
// OtherCount: 100500,
// }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// um.fileCounts = &service.FileCounts{
// WandbCount: 42,
// MediaCount: 420,
// ArtifactCount: -1,
// OtherCount: 100500,
// }

@github-actions github-actions bot added cc-feat and removed cc-feat labels Oct 9, 2023
nexus/pkg/server/server.go Outdated Show resolved Hide resolved
nexus/pkg/server/server.go Outdated Show resolved Hide resolved
@dmitryduev dmitryduev merged commit 67166dd into main Oct 9, 2023
69 checks passed
@dmitryduev dmitryduev deleted the nexus-file-counts branch October 9, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants