Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(artifacts): fix the argument order for new argument target_fraction #6377

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

moredatarequired
Copy link
Contributor

@moredatarequired moredatarequired commented Sep 27, 2023

Fixes

  • Fixes WB-NNNNN
  • Fixes #NNNN

Description

The new argument target_fraction should have been added at the end of the argument list, rather than after target_size.

馃 Generated by Copilot at f6865bb

Refactored the cleanup function of the ArtifactsCache class in wandb/sdk/artifacts/artifacts_cache.py to make the code more clear and consistent.

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

馃 Generated by Copilot at f6865bb

To make the code more consistent
The cleanup function was insistent
On changing the order
Of args and doc border
And now it looks much more persistent

@github-actions github-actions bot added cc-fix and removed cc-fix labels Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #6377 (f6865bb) into main (f0caa63) will decrease coverage by 0.09%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6377      +/-   ##
==========================================
- Coverage   77.24%   77.15%   -0.09%     
==========================================
  Files         388      388              
  Lines       44513    44513              
==========================================
- Hits        34384    34346      -38     
- Misses      10075    10113      +38     
  Partials       54       54              
Flag Coverage 螖
unittest 80.94% <酶> (-0.10%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage 螖
wandb/sdk/artifacts/artifacts_cache.py 92.59% <酶> (酶)

... and 12 files with indirect coverage changes

@moredatarequired moredatarequired marked this pull request as ready for review September 27, 2023 18:58
@github-actions github-actions bot added cc-fix and removed cc-fix labels Sep 27, 2023
@moredatarequired moredatarequired merged commit c0c827a into main Sep 27, 2023
83 of 85 checks passed
@moredatarequired moredatarequired deleted the cache-target-fraction-arg-order branch September 27, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants