Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nexus): fix potential race in config debouncer #6385

Merged
merged 5 commits into from
Sep 29, 2023
Merged

Conversation

dmitryduev
Copy link
Member

@dmitryduev dmitryduev commented Sep 28, 2023

Fixes

  • Fixes WB-NNNNN
  • Fixes #NNNN

Description

What does the PR do?

馃 Generated by Copilot at e0409bc

Refactored and improved the debouncing logic for config and metric updates in the nexus server and client. Simplified the debounce package and its tests, and updated the system tests to match the new behavior.

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

馃 Generated by Copilot at e0409bc

We've got a new debouncer in our code, me hearties
It's simpler and faster than the old one, so they say
So let's test it well and make sure it works, on the count of three
Heave ho, heave ho, configDebouncer away

@dmitryduev dmitryduev requested a review from a team as a code owner September 28, 2023 21:46
@dmitryduev dmitryduev changed the title Dedebounce fix(nexus): fix potential race in config debouncer Sep 28, 2023
@github-actions github-actions bot added cc-fix and removed cc-fix labels Sep 28, 2023
@dmitryduev dmitryduev changed the title fix(nexus): fix potential race in config debouncer fix(nexus): fix potential race in config debouncer Sep 29, 2023
@github-actions github-actions bot added cc-fix and removed cc-fix labels Sep 29, 2023
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #6385 (af75ae2) into main (50d613f) will decrease coverage by 3.87%.
Report is 1 commits behind head on main.
The diff coverage is 85.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6385      +/-   ##
==========================================
- Coverage   81.03%   77.16%   -3.87%     
==========================================
  Files         362      388      +26     
  Lines       41768    44524    +2756     
==========================================
+ Hits        33846    34357     +511     
- Misses       7922    10114    +2192     
- Partials        0       53      +53     
Flag Coverage 螖
unittest 80.97% <酶> (-0.07%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage 螖
nexus/internal/debounce/debounce.go 100.00% <100.00%> (酶)
nexus/pkg/server/sender.go 17.06% <0.00%> (酶)

... and 44 files with indirect coverage changes

@dmitryduev dmitryduev merged commit 7a8202a into main Sep 29, 2023
78 of 79 checks passed
@dmitryduev dmitryduev deleted the dedebounce branch September 29, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants