-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk): fix step logic when resuming runs with no metrics logged #6480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisbergua
changed the title
Wb 15093
fix(sdk) fix step logic when resuming runs with no metrics logged
Oct 20, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6480 +/- ##
==========================================
- Coverage 77.03% 76.96% -0.07%
==========================================
Files 389 389
Lines 45188 45190 +2
==========================================
- Hits 34809 34780 -29
- Misses 10326 10357 +31
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more.
|
luisbergua
changed the title
fix(sdk) fix step logic when resuming runs with no metrics logged
fix(sdk): fix step logic when resuming runs with no metrics logged
Oct 20, 2023
kptkin
reviewed
Oct 27, 2023
Co-authored-by: Katia Patkin <87335417+kptkin@users.noreply.github.com>
kptkin
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does the PR do?
When resuming a run, the step is incremented by 1 to avoid overwriting the last step. The problem is that, if the run didn't log any metrics, the step is still being increased by 1:
prints:
This PR handles that specific case by checking if the summary contains any user-logged metrics and only increasing the step by 1 in that case. This is to avoid setting
_step
to 0 if only 1 step was logged as"_step" = n_steps - 1
so ifn_steps=1
then_step
will still be 0馃 Generated by Copilot at c9b9b9a
Fix a bug in
SendManager
that caused incorrect step increment when resuming a run with only system metrics. Update the logic for setting the resume state step insender.py
to check for user-defined data in the summary.Testing
How was this PR tested? Checking different cases before and after the fix:
Before:
After:
Before:
After:
Before:
After:
馃 Generated by Copilot at c9b9b9a