Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): add warning when log_code can't locate any files #6532

Merged
merged 8 commits into from
Nov 6, 2023
Merged

Conversation

umakrishnaswamy
Copy link
Contributor

@umakrishnaswamy umakrishnaswamy commented Oct 31, 2023

Description

What does the PR do?
adds a warning when log_code is called in a directory with no .py files or dockerfiles

馃 Generated by Copilot at 5163052

Add a warning for missing code files in log_code. This helps the user to know if their wandb run will not have any code or Dockerfile logged.

Testing

How was this PR tested?
run in empty directories and full directories and warning performs as expected

馃 Generated by Copilot at 5163052

log_code warns you
No files found in the dir
Autumn of repro

@github-actions github-actions bot added cc-feat and removed cc-feat labels Oct 31, 2023
@umakrishnaswamy umakrishnaswamy requested a review from a team October 31, 2023 22:47
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #6532 (476f08b) into main (56670eb) will decrease coverage by 0.28%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6532      +/-   ##
==========================================
- Coverage   76.42%   76.15%   -0.28%     
==========================================
  Files         392      392              
  Lines       45551    45552       +1     
==========================================
- Hits        34811    34688     -123     
- Misses      10680    10804     +124     
  Partials       60       60              
Flag Coverage 螖
unittest 80.89% <0.00%> (-0.30%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage 螖
wandb/sdk/wandb_run.py 89.75% <0.00%> (-0.11%) 猬囷笍

... and 16 files with indirect coverage changes

wandb/sdk/wandb_run.py Outdated Show resolved Hide resolved
wandb/sdk/wandb_run.py Outdated Show resolved Hide resolved
@kptkin kptkin added this to the sdk-2023-11.1 milestone Nov 2, 2023
@kptkin kptkin changed the title feat(sdk): add warning when log_code is called with no py files or dockerfiles present feat(sdk): add warning when log_code can't locate any files Nov 6, 2023
@kptkin kptkin changed the title feat(sdk): add warning when log_code can't locate any files fix(sdk): add warning when log_code can't locate any files Nov 6, 2023
@kptkin kptkin merged commit b86aaff into main Nov 6, 2023
85 of 88 checks passed
@kptkin kptkin deleted the code_warning branch November 6, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants