-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk): add warning when log_code
can't locate any files
#6532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6532 +/- ##
==========================================
- Coverage 76.42% 76.15% -0.28%
==========================================
Files 392 392
Lines 45551 45552 +1
==========================================
- Hits 34811 34688 -123
- Misses 10680 10804 +124
Partials 60 60
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kptkin
reviewed
Nov 1, 2023
kptkin
reviewed
Nov 1, 2023
kptkin
approved these changes
Nov 2, 2023
kptkin
changed the title
feat(sdk): add warning when log_code is called with no py files or dockerfiles present
feat(sdk): add warning when log_code can't locate any files
Nov 6, 2023
kptkin
changed the title
feat(sdk): add warning when log_code can't locate any files
fix(sdk): add warning when Nov 6, 2023
log_code
can't locate any files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does the PR do?
adds a warning when log_code is called in a directory with no .py files or dockerfiles
馃 Generated by Copilot at 5163052
Add a warning for missing code files in
log_code
. This helps the user to know if their wandb run will not have any code or Dockerfile logged.Testing
How was this PR tested?
run in empty directories and full directories and warning performs as expected
馃 Generated by Copilot at 5163052