Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add wandb beta sync feature to upload runs to W&B #6620

Merged
merged 60 commits into from
Dec 9, 2023

Conversation

kptkin
Copy link
Contributor

@kptkin kptkin commented Nov 21, 2023

Description

  • Fixes WB-NNNNN
  • Fixes #NNNN

What does the PR do?

🤖[deprecated] Generated by Copilot at f49c0f6

No summary available (Limit exceeded: required to process 50505 tokens, but only 50000 are allowed per call)

Testing

How was this PR tested?

🤖[deprecated] Generated by Copilot at 10f1bf0

Oh we are the wandb crew and we have a job to do
We sync our runs to the cloud with the wandb sync command
We send our sync requests and we handle the responses
We heave away and haul away and sync our data grand

@github-actions github-actions bot added cc-feat and removed cc-feat labels Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #6620 (10f1bf0) into main (beb4972) will increase coverage by 0.51%.
The diff coverage is 78.39%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6620      +/-   ##
==========================================
+ Coverage   78.82%   79.34%   +0.51%     
==========================================
  Files         426      428       +2     
  Lines       48641    48979     +338     
==========================================
+ Hits        38343    38864     +521     
+ Misses      10065     9880     -185     
- Partials      233      235       +2     
Flag Coverage Δ
func 52.18% <34.81%> (-0.06%) ⬇️
system 63.78% <78.39%> (+1.47%) ⬆️
unit 60.69% <21.85%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/pkg/server/stream.go 97.97% <100.00%> (ø)
core/pkg/server/writer.go 84.72% <100.00%> (+0.89%) ⬆️
wandb/__init__.py 94.59% <100.00%> (+3.21%) ⬆️
wandb/sdk/__init__.py 100.00% <100.00%> (ø)
wandb/sdk/interface/interface_shared.py 90.60% <100.00%> (+0.97%) ⬆️
wandb/sdk/service/service_base.py 83.33% <100.00%> (-2.39%) ⬇️
wandb/sdk/service/service_sock.py 100.00% <100.00%> (ø)
wandb/sdk/wandb_init.py 91.65% <100.00%> (ø)
wandb/sdk/wandb_manager.py 94.11% <100.00%> (+1.30%) ⬆️
wandb/sync/sync.py 90.35% <100.00%> (+13.84%) ⬆️
... and 6 more

... and 28 files with indirect coverage changes

@dmitryduev dmitryduev changed the title feat(nexus): offline sync feat(core): offline sync Dec 9, 2023
@github-actions github-actions bot added cc-feat and removed cc-feat labels Dec 9, 2023
@dmitryduev dmitryduev changed the title feat(core): offline sync feat(core): add wandb beta sync feature to upload runs to W&B Dec 9, 2023
@dmitryduev dmitryduev marked this pull request as ready for review December 9, 2023 00:48
@dmitryduev dmitryduev requested a review from a team as a code owner December 9, 2023 00:48
@github-actions github-actions bot added cc-feat and removed cc-feat labels Dec 9, 2023
wandb/cli/cli.py Outdated Show resolved Hide resolved
@dmitryduev dmitryduev self-requested a review December 9, 2023 01:08
Copy link
Member

@dmitryduev dmitryduev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a wild ride!

@github-actions github-actions bot added cc-feat and removed cc-feat labels Dec 9, 2023
@github-actions github-actions bot added cc-feat and removed cc-feat labels Dec 9, 2023
@kptkin kptkin merged commit ce63eef into main Dec 9, 2023
77 of 78 checks passed
@kptkin kptkin deleted the offline-sync branch December 9, 2023 01:49
@kptkin kptkin added this to the sdk-2024-01.1 milestone Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants