Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(integrations): tmin vs tmax in wandb/wandb_torch.py::log_tensor_stats #6641

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

dmitryduev
Copy link
Member

@dmitryduev dmitryduev commented Nov 28, 2023

Description

  • Fixes WB-NNNNN
  • Fixes #NNNN

What does the PR do?

Follow up on #6640

Testing

How was this PR tested?

🤖[deprecated] Generated by Copilot at 895c8f0

wandb_torch fixed
histograms and tensors cloned
autumn leaves the graph

@dmitryduev dmitryduev added this to the sdk-2023-12.1 milestone Nov 28, 2023
@github-actions github-actions bot added cc-fix and removed cc-fix labels Nov 28, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #6641 (895c8f0) into main (3d77ffc) will decrease coverage by 1.17%.
The diff coverage is 66.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6641      +/-   ##
==========================================
- Coverage   79.36%   78.19%   -1.17%     
==========================================
  Files         415      415              
  Lines       47712    47714       +2     
==========================================
- Hits        37866    37312     -554     
- Misses       9635    10192     +557     
+ Partials      211      210       -1     
Flag Coverage Δ
func 50.98% <66.66%> (-1.92%) ⬇️
system 61.88% <66.66%> (-1.19%) ⬇️
unit 61.03% <0.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
wandb/wandb_torch.py 62.41% <66.66%> (-0.09%) ⬇️

... and 41 files with indirect coverage changes

@dmitryduev dmitryduev merged commit ec7c53a into main Nov 29, 2023
76 of 79 checks passed
@dmitryduev dmitryduev deleted the wbtormima branch November 29, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants