Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(launch): CLI supports allow-listed queue parameters #6679

Merged
merged 12 commits into from
Dec 13, 2023
Merged

Conversation

TimH98
Copy link
Contributor

@TimH98 TimH98 commented Dec 7, 2023

Description

Add the ability to specify a queue's allowlisted parameters from the CLI, using the --field flag.

Example: wandb launch [...] --fields key1=some_string --fields key2=3.0

馃[deprecated] Generated by Copilot at 794ee48

This pull request adds support for template variables in run queues, which enable users to customize the resource configuration for launching runs. It modifies the RunQueue class in wandb/apis/public.py, the launch command in wandb/cli/cli.py, and adds a new function in wandb/sdk/launch/utils.py to fetch and validate the template variables.

Testing

Tested manually by using the CLI, including attempting to use invalid field names and values. System test coming soon.

馃[deprecated] Generated by Copilot at 794ee48

Launch runs from queue
With --fields option
Autumn leaves fall fast

@TimH98 TimH98 requested a review from a team December 7, 2023 21:21
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #6679 (1cebf80) into main (ba514ed) will decrease coverage by 3.56%.
The diff coverage is 12.19%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6679      +/-   ##
==========================================
- Coverage   79.21%   75.66%   -3.56%     
==========================================
  Files         430      430              
  Lines       49183    49224      +41     
==========================================
- Hits        38959    37243    -1716     
- Misses       9990    11747    +1757     
  Partials      234      234              
Flag Coverage 螖
func 52.04% <12.19%> (-0.01%) 猬囷笍
system 60.02% <12.19%> (-3.35%) 猬囷笍
unit 57.54% <12.19%> (-3.47%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage 螖
wandb/apis/public.py 72.83% <22.22%> (-4.50%) 猬囷笍
wandb/cli/cli.py 52.14% <22.22%> (-12.04%) 猬囷笍
wandb/sdk/launch/utils.py 32.43% <4.34%> (-49.76%) 猬囷笍

... and 45 files with indirect coverage changes

@github-actions github-actions bot added cc-feat and removed cc-feat labels Dec 7, 2023
wandb/cli/cli.py Outdated Show resolved Hide resolved
wandb/sdk/launch/utils.py Show resolved Hide resolved
wandb/cli/cli.py Outdated Show resolved Hide resolved
Copy link
Contributor

@bcsherma bcsherma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just a few comments about error paths (hot on my mind at the moment xD)

wandb/sdk/launch/utils.py Outdated Show resolved Hide resolved
wandb/sdk/launch/utils.py Show resolved Hide resolved
@TimH98 TimH98 merged commit 98f3b93 into main Dec 13, 2023
70 of 75 checks passed
@TimH98 TimH98 deleted the allowlist-cli branch December 13, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants