Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(artifacts): remove run creation for artifact downloads if not using core #6746

Merged
merged 5 commits into from
Dec 18, 2023

Conversation

ibindlish
Copy link
Contributor

@ibindlish ibindlish commented Dec 18, 2023

Description

What does the PR do?

Run creation was made a part of artifacts downloads to communicate with the wandb core process. Since artifact downloads are not a part of the python core, we can avoid run creation unless users install and wish to use wandb-core. In the future, instead of creating a run, we will explore using streams to communicate with the core.

Testing

api = wandb.Api()
artifact = api.artifact('test-paige/uncategorized/b2:v0')
path = artifact.download()

tested and verified that runs are created only if wandb-core is installed

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #6746 (135f4b3) into main (0f9d8dd) will decrease coverage by 0.02%.
The diff coverage is 81.81%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6746      +/-   ##
==========================================
- Coverage   79.45%   79.43%   -0.02%     
==========================================
  Files         447      447              
  Lines       49558    49557       -1     
==========================================
- Hits        39376    39367       -9     
- Misses       9936     9945       +9     
+ Partials      246      245       -1     
Flag Coverage Δ
func 52.12% <13.63%> (-0.01%) ⬇️
system 63.66% <81.81%> (-0.27%) ⬇️
unit 58.86% <4.54%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
wandb/sdk/artifacts/artifact.py 92.51% <81.81%> (-0.01%) ⬇️

... and 17 files with indirect coverage changes

@github-actions github-actions bot added cc-fix and removed cc-fix labels Dec 18, 2023
@github-actions github-actions bot added cc-fix and removed cc-fix labels Dec 18, 2023
@ibindlish ibindlish marked this pull request as ready for review December 18, 2023 19:56
@ibindlish ibindlish requested a review from a team as a code owner December 18, 2023 19:56
@ibindlish ibindlish added this to the sdk-2024-01.1 milestone Dec 18, 2023
@ibindlish ibindlish merged commit d92e71e into main Dec 18, 2023
75 of 76 checks passed
@ibindlish ibindlish deleted the ibindlish/artifacts/remove-run-non-core branch December 18, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants