Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add TensorBoard log dir watcher #6769

Merged
merged 10 commits into from
Jan 3, 2024
Merged

feat(core): add TensorBoard log dir watcher #6769

merged 10 commits into from
Jan 3, 2024

Conversation

kptkin
Copy link
Contributor

@kptkin kptkin commented Dec 24, 2023

Description

  • Fixes WB-NNNNN
  • Fixes #NNNN

Implement basic Tensorboard sync feature in wandb-core: tfevent files will now be synced to the run so that a TB tab will be available in the FE.

  • Generalize the watcher to support custom handle functions
  • Use it to implement a TB log dir watcher that tracks the TB event files so that we upload them at the end of a run.

Testing

How was this PR tested?

Copy link

codecov bot commented Dec 24, 2023

Codecov Report

Attention: 103 lines in your changes are missing coverage. Please review.

Comparison is base (f513753) 79.46% compared to head (67a7fef) 79.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6769      +/-   ##
==========================================
- Coverage   79.46%   79.33%   -0.13%     
==========================================
  Files         447      450       +3     
  Lines       49667    49798     +131     
==========================================
+ Hits        39466    39509      +43     
- Misses       9955    10041      +86     
- Partials      246      248       +2     
Flag Coverage Δ
func 52.13% <ø> (-0.01%) ⬇️
system 63.89% <50.95%> (-0.11%) ⬇️
unit 58.72% <28.57%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/internal/watcher/registry.go 100.00% <100.00%> (ø)
core/pkg/monitor/monitor.go 83.56% <ø> (ø)
core/pkg/server/files.go 85.03% <100.00%> (+1.95%) ⬆️
core/pkg/server/stream.go 100.00% <100.00%> (ø)
core/internal/watcher/event.go 50.00% <50.00%> (ø)
core/pkg/server/handler.go 78.78% <45.45%> (-0.57%) ⬇️
core/internal/watcher/watcher.go 65.62% <63.41%> (-12.79%) ⬇️
core/pkg/server/tb.go 18.18% <18.18%> (ø)

... and 17 files with indirect coverage changes

@kptkin kptkin changed the title generalize watcher fix(core): generalize the watcher to support custom handle function Dec 25, 2023
@dmitryduev dmitryduev marked this pull request as ready for review January 2, 2024 20:05
@dmitryduev dmitryduev requested a review from a team as a code owner January 2, 2024 20:05
@dmitryduev dmitryduev changed the title fix(core): generalize the watcher to support custom handle function feat(core): add TensorBoard log dir watcher Jan 3, 2024
Copy link
Member

@dmitryduev dmitryduev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎁🎄🎁

@dmitryduev dmitryduev merged commit 2200290 into main Jan 3, 2024
78 of 79 checks passed
@dmitryduev dmitryduev deleted the fix-watcher branch January 3, 2024 01:48
@github-actions github-actions bot added cc-feat and removed cc-feat labels Jan 3, 2024
@kptkin kptkin added this to the sdk-2024-01.1 milestone Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants