Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): generate data type info in core #6827

Merged
merged 15 commits into from
Jan 12, 2024
Merged

feat(core): generate data type info in core #6827

merged 15 commits into from
Jan 12, 2024

Conversation

dmitryduev
Copy link
Member

@dmitryduev dmitryduev commented Jan 11, 2024

Description

  • Fixes WB-NNNNN
  • Fixes #NNNN

What does the PR do?

Implement basic internal type representation necessary for generating input and output types (from config and summary, respectively) for launch jobs.

Testing

How was this PR tested?

@dmitryduev dmitryduev requested a review from a team as a code owner January 11, 2024 21:48
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (9c7a31f) 77.27% compared to head (d912d28) 77.22%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6827      +/-   ##
==========================================
- Coverage   77.27%   77.22%   -0.05%     
==========================================
  Files         450      451       +1     
  Lines       49939    50021      +82     
==========================================
+ Hits        38588    38631      +43     
- Misses      11080    11133      +53     
+ Partials      271      257      -14     
Flag Coverage Δ
func 49.24% <100.00%> (-2.07%) ⬇️
system 62.48% <100.00%> (-0.18%) ⬇️
unit 58.65% <79.06%> (+2.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
wandb/sdk/data_types/_dtypes.py 95.22% <100.00%> (-0.25%) ⬇️
core/internal/data_types/data_types.go 78.82% <78.82%> (ø)

... and 84 files with indirect coverage changes

@github-actions github-actions bot added cc-feat and removed cc-feat labels Jan 11, 2024
@dmitryduev dmitryduev merged commit c7a399e into main Jan 12, 2024
74 of 77 checks passed
@dmitryduev dmitryduev deleted the go-type-yourself branch January 12, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants