Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(artifacts): fix long artifact paths on Windows #6846

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

ArtsiomWB
Copy link
Contributor

Description

No JIRA ticket yet

  • Fixes WB-NNNNN

  • Fixes #NNNN

  • fixes Volkswagen's blocker regarding artifact.download()

What does the PR do?

The PR normalizes the Path we receive once an artifact is downloaded. By adding:
path = str(Path(self.path)) to the path generating process, we translate the relative path of entry into a system path before it is added to the root path.

Testing

How was this PR tested?

Tested using Artifact tests that are built into wandb/wandb

@ArtsiomWB ArtsiomWB requested a review from a team as a code owner January 17, 2024 06:45
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cb62d98) 79.65% compared to head (9c0f3fd) 79.71%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6846      +/-   ##
==========================================
+ Coverage   79.65%   79.71%   +0.05%     
==========================================
  Files         452      452              
  Lines       50747    50748       +1     
==========================================
+ Hits        40423    40453      +30     
+ Misses      10029    10000      -29     
  Partials      295      295              
Flag Coverage Δ
func 50.23% <100.00%> (-0.01%) ⬇️
system 64.39% <100.00%> (+<0.01%) ⬆️
unit 58.99% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
wandb/sdk/artifacts/artifact_manifest_entry.py 94.11% <100.00%> (+0.07%) ⬆️

... and 15 files with indirect coverage changes

Copy link
Contributor

@estellazx estellazx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be good, I tested to make sure nothing broke but didn't reproduce the customers usecase

@ArtsiomWB ArtsiomWB merged commit d10f170 into main Jan 30, 2024
78 of 81 checks passed
@ArtsiomWB ArtsiomWB deleted the artifactPathing-ci-win branch January 30, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants