fix(artifacts): fix long artifact paths on Windows #6846
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No JIRA ticket yet
Fixes WB-NNNNN
Fixes #NNNN
fixes Volkswagen's blocker regarding artifact.download()
What does the PR do?
The PR normalizes the Path we receive once an artifact is downloaded. By adding:
path = str(Path(self.path))
to the path generating process, we translate the relative path of entry into a system path before it is added to the root path.Testing
How was this PR tested?
Tested using Artifact tests that are built into wandb/wandb