Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): fix retry logic in wandb-core and system_tests conftest #6847

Merged
merged 13 commits into from
Jan 18, 2024

Conversation

dmitryduev
Copy link
Member

@dmitryduev dmitryduev commented Jan 17, 2024

Description

  • Fixes WB-NNNNN
  • Fixes #NNNN

What does the PR do?

  • Fixed a gnarly bug in our HTTP retry logic related to time conversions.
  • Fixed and cleaned up system_test's conftest, in particular:

Testing

How was this PR tested?
Manually + go unit tests + system tests

@dmitryduev dmitryduev requested a review from a team January 17, 2024 21:18
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5081aed) 79.36% compared to head (baa72d9) 79.35%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6847      +/-   ##
==========================================
- Coverage   79.36%   79.35%   -0.01%     
==========================================
  Files         452      452              
  Lines       50615    50618       +3     
==========================================
  Hits        40170    40170              
- Misses      10152    10157       +5     
+ Partials      293      291       -2     
Flag Coverage Δ
func 50.41% <100.00%> (-1.69%) ⬇️
system 64.40% <85.71%> (+0.59%) ⬆️
unit 58.84% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/internal/clients/backoff.go 100.00% <100.00%> (ø)
core/internal/clients/clients.go 95.12% <100.00%> (+0.25%) ⬆️
core/pkg/server/sender.go 83.21% <100.00%> (+0.52%) ⬆️
wandb/sdk/wandb_settings.py 93.22% <100.00%> (ø)

... and 33 files with indirect coverage changes

@dmitryduev dmitryduev changed the title test(sdk): fix and clean up the broken system_tests' conftest fix(sdk): fix retry logic and clean up the broken system_tests conftest Jan 18, 2024
@dmitryduev dmitryduev changed the title fix(sdk): fix retry logic and clean up the broken system_tests conftest fix(core): fix retry logic and clean up the broken system_tests conftest Jan 18, 2024
@github-actions github-actions bot removed the cc-fix label Jan 18, 2024
@dmitryduev dmitryduev changed the title fix(core): fix retry logic and clean up the broken system_tests conftest fix(sdk): fix retry logic in wandb-core and clean up the broken system_tests conftest Jan 18, 2024
@github-actions github-actions bot added cc-fix and removed cc-fix labels Jan 18, 2024
@dmitryduev dmitryduev changed the title fix(sdk): fix retry logic in wandb-core and clean up the broken system_tests conftest fix(sdk): fix retry logic in wandb-core and fix system_tests conftest Jan 18, 2024
@dmitryduev dmitryduev changed the title fix(sdk): fix retry logic in wandb-core and fix system_tests conftest fix(sdk): fix retry logic in wandb-core and system_tests conftest Jan 18, 2024
@github-actions github-actions bot added cc-fix and removed cc-fix labels Jan 18, 2024
@dmitryduev dmitryduev merged commit 92353fc into main Jan 18, 2024
85 checks passed
@dmitryduev dmitryduev deleted the fix-conftest branch January 18, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants