Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): fix _parse_path when only id is passed to wandb.Api().run() #6858

Merged
merged 8 commits into from
Jan 22, 2024

Conversation

luisbergua
Copy link
Contributor

@luisbergua luisbergua commented Jan 19, 2024

Description

What does the PR do?

Fixes the case when only passing id to wandb.Api().run() like:

import wandb
api = wandb.Api(overrides={
    "entity": entity_name,
    "project": project_name,
  })
api.run(path=run_id)

_parse_path is incorrectly returning the id as project, causing CommError: Could not find run <Run entity_name/run_id/run_id (not found)>

Testing

How was this PR tested? Executing the code snippet before and after the change

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (753d6e7) 79.55% compared to head (68ad9e8) 79.55%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6858   +/-   ##
=======================================
  Coverage   79.55%   79.55%           
=======================================
  Files         452      452           
  Lines       50663    50665    +2     
=======================================
+ Hits        40304    40306    +2     
  Misses      10069    10069           
  Partials      290      290           
Flag Coverage Δ
func 52.02% <0.00%> (+0.02%) ⬆️
system 64.28% <66.66%> (-0.10%) ⬇️
unit 58.93% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
wandb/apis/public/api.py 83.13% <100.00%> (+0.09%) ⬆️

... and 7 files with indirect coverage changes

@github-actions github-actions bot added cc-fix and removed cc-fix labels Jan 19, 2024
@luisbergua luisbergua merged commit cab4354 into main Jan 22, 2024
77 checks passed
@luisbergua luisbergua deleted the WB-11095 branch January 22, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants