-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): add shared mode to enable multiple independent writers to the same run #6882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6882 +/- ##
==========================================
+ Coverage 79.54% 79.64% +0.10%
==========================================
Files 452 452
Lines 50667 50712 +45
==========================================
+ Hits 40302 40390 +88
+ Misses 10074 10027 -47
- Partials 291 295 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kptkin
reviewed
Jan 23, 2024
kptkin
reviewed
Jan 23, 2024
kptkin
reviewed
Jan 23, 2024
kptkin
reviewed
Jan 23, 2024
kptkin
changed the title
feat(sdk): make attach interplanetary
feat(sdk): asyncify my run
Jan 23, 2024
kptkin
reviewed
Jan 23, 2024
kptkin
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make it possible to log to the same run using multiple writers with independent
wandb-core
's (including ones running, for example, on different machines):NOTE: This feature only works with SDK's new backend,
wandb-core
. As of version 0.17.0, you must explicitly opt into using the new backend:wandb.require("core")
.To run the example below, do:
pip install -U wandb # run the fake training script: python train.py
A simple example that runs a training script and every 20 epochs spins up an independent eval job (that uses its own
wandb-core
, mimicking a situation where it's running on a different machine):train.py
eval.py
TODO
train.py
andeval.py
Testing
How was this PR tested?