fix(media): Update video.py: Fix fps bug #6887
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change imageio to the updated parameter
fps
fromduration
. I am a first time contributor, please let me know if I need to change the format of the PR. I like using wandb, and believe people can benefit from this fix :)Description
When I log gifs from numpy arrays to wandb, even when the frame rate is passed, it does not seem to obey it. This fix ensures that the correct frame rate gif is created and logged to the wandb console.
Testing
In the examples below, I log a video with the same number of frames (44) using the following piece of code. The output duration of the gif should be 44/24 = 1.76 seconds. However, as visible below, the before gif has a longer duration.
Before:
After: