-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(artifacts): Add partial file downloads, via directory prefix #6911
Conversation
30c573c
to
4f19c19
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6911 +/- ##
==========================================
+ Coverage 77.75% 79.63% +1.87%
==========================================
Files 452 452
Lines 50734 50747 +13
==========================================
+ Hits 39450 40412 +962
+ Misses 10989 10040 -949
Partials 295 295
Flags with carried forward coverage won't be shown. Click here to find out more.
|
4f19c19
to
ca36d98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@biaslucas I'm wondering if its worth checking whether the path passed in is a file and not a directory, then should we revert to directly downloading a single file instead of iterating over the entire manifest?
ca36d98
to
51b5b4f
Compare
I think the argument name is |
You're right! Thank you - and apologies since this was misleading! |
Description
What does the PR do?
Read: https://wandb.atlassian.net/browse/WB-13672
Testing
Download prefix case:
Result:
Basecase (no arg given and we download everything):
Final comments: this method is easier to code but a little off from the 'optimal' way of doing things. Ideally within the graphQL query itself we specific a prefix and in the backend we do the filtering. however for now we will just filter after querying filenames (but importantly BEFORE we actually download the files).
There should be ample communication to clients that this argument is prefix / directory filtering for W&B FILEPATHS, not REFERENCE PATHS! they are not the same