Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): Update Report API to work with pydantic2.6 #6925

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

andrewtruong
Copy link
Contributor

@andrewtruong andrewtruong commented Jan 31, 2024

Description

Pydantic 2.6 introduces some changes to dataclasses that caused our old internal attr setting to break. This PR fixes that.

Testing

How was this PR tested?

unit tests

@andrewtruong andrewtruong requested a review from a team January 31, 2024 04:21
@github-actions github-actions bot added cc-fix and removed cc-fix labels Jan 31, 2024
@andrewtruong andrewtruong added this to the sdk-2024-02.1 milestone Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d40b2a5) 77.09% compared to head (c3d7742) 79.74%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6925      +/-   ##
==========================================
+ Coverage   77.09%   79.74%   +2.64%     
==========================================
  Files         462      462              
  Lines       52662    52681      +19     
==========================================
+ Hits        40602    42011    +1409     
+ Misses      11765    10375    -1390     
  Partials      295      295              
Flag Coverage Δ
func 48.74% <0.00%> (-0.04%) ⬇️
system 62.04% <0.00%> (+0.03%) ⬆️
unit 59.44% <100.00%> (+2.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
wandb/apis/reports/v2/interface.py 79.81% <100.00%> (+79.81%) ⬆️

... and 12 files with indirect coverage changes

tox.ini Outdated Show resolved Hide resolved
@kptkin kptkin merged commit 7d974e7 into main Jan 31, 2024
79 checks passed
@kptkin kptkin deleted the andrew/report-api-fixes-pydantic26 branch January 31, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants