Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(artifacts): artifact file upload progress in nexus #6939

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

ibindlish
Copy link
Contributor

@ibindlish ibindlish commented Feb 2, 2024

Description

What does the PR do?

Include a concise description of the PR contents

Testing

Todo: Add test

@ibindlish ibindlish requested a review from a team as a code owner February 2, 2024 20:53
@ibindlish ibindlish changed the title fix(artifacts): upload progress in nexus fix(artifacts): artifact file upload progress in nexus Feb 2, 2024
@github-actions github-actions bot added cc-fix and removed cc-fix labels Feb 2, 2024
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (2165475) 79.71% compared to head (868a55e) 79.73%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6939      +/-   ##
==========================================
+ Coverage   79.71%   79.73%   +0.02%     
==========================================
  Files         462      462              
  Lines       52685    52708      +23     
==========================================
+ Hits        41999    42029      +30     
+ Misses      10391    10383       -8     
- Partials      295      296       +1     
Flag Coverage Δ
func 48.75% <0.00%> (-0.01%) ⬇️
system 62.02% <86.95%> (+0.03%) ⬆️
unit 59.41% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/pkg/artifacts/saver.go 74.50% <86.95%> (+0.86%) ⬆️

... and 9 files with indirect coverage changes

@github-actions github-actions bot added cc-fix and removed cc-fix labels Feb 2, 2024
Copy link
Member

@dmitryduev dmitryduev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, thank you @ibindlish!!

@dmitryduev dmitryduev merged commit 8cd0390 into main Feb 3, 2024
86 checks passed
@dmitryduev dmitryduev deleted the ibindlish/artifacts/upload-progress-nexus branch February 3, 2024 00:19
@github-actions github-actions bot added cc-fix and removed cc-fix labels Feb 3, 2024
@ender-wieczorek
Copy link

Todo: Add test

😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants