Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(artifacts): make 'policy' choice option for artifact cli's put method #7172

Merged

Conversation

ibindlish
Copy link
Contributor

@ibindlish ibindlish commented Mar 18, 2024

Description

Addressing post-merge comment: #7098 (comment)

  • I updated CHANGELOG.md, or it's not applicable

Testing

wandb artifact put --policy 'temp'

Error: Invalid value for '--policy': 'temp' is not one of 'mutable', 'immutable'.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.81%. Comparing base (01a103c) to head (26df444).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7172      +/-   ##
==========================================
- Coverage   76.23%   74.81%   -1.43%     
==========================================
  Files         509      509              
  Lines       54044    54042       -2     
==========================================
- Hits        41203    40429     -774     
- Misses      12488    13257     +769     
- Partials      353      356       +3     
Flag Coverage Δ
func 43.91% <100.00%> (+0.14%) ⬆️
system 64.87% <100.00%> (+0.35%) ⬆️
unit 54.58% <100.00%> (-3.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
wandb/cli/cli.py 60.81% <ø> (-3.87%) ⬇️
wandb/sdk/artifacts/artifact_saver.py 95.40% <100.00%> (-0.11%) ⬇️

... and 47 files with indirect coverage changes

ibindlish and others added 3 commits March 18, 2024 12:50
…nges' of github.com:wandb/wandb into ibindlish/artifacts/post-merge-comments-for-staging-changes
@ibindlish ibindlish requested a review from a team as a code owner March 18, 2024 19:56
Copy link
Contributor

@estellazx estellazx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ibindlish ibindlish added this to the sdk-2024-04.1 milestone Mar 21, 2024
@kptkin kptkin modified the milestones: sdk-2024-04.1, sdk-2024-05.1 Mar 25, 2024
@kptkin kptkin removed this from the sdk-2024-05.1 milestone Mar 25, 2024
@ibindlish ibindlish merged commit e65964c into main Mar 26, 2024
58 checks passed
@ibindlish ibindlish deleted the ibindlish/artifacts/post-merge-comments-for-staging-changes branch March 26, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants