-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sdk): adding back the required flag for wandb-core
#7228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7228 +/- ##
==========================================
- Coverage 76.06% 75.14% -0.92%
==========================================
Files 512 512
Lines 54343 54362 +19
==========================================
- Hits 41337 40853 -484
- Misses 12639 13145 +506
+ Partials 367 364 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kptkin
force-pushed
the
kpt/require_wandb_core
branch
from
April 4, 2024 01:38
be3d983
to
c977292
Compare
dmitryduev
approved these changes
Apr 4, 2024
kptkin
commented
Apr 8, 2024
timoffex
reviewed
Apr 8, 2024
tests/pytest_tests/system_tests/test_notebooks/test_notebooks.py
Outdated
Show resolved
Hide resolved
kptkin
commented
Apr 9, 2024
timoffex
reviewed
Apr 9, 2024
timoffex
approved these changes
Apr 9, 2024
ibindlish
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does the PR do? Include a concise description of the PR contents.
Testing
How was this PR tested?
added several unit tests and tested manually