Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): adding back the required flag for wandb-core #7228

Merged
merged 17 commits into from
Apr 9, 2024

Conversation

kptkin
Copy link
Contributor

@kptkin kptkin commented Mar 26, 2024

Description

What does the PR do? Include a concise description of the PR contents.

  • I updated CHANGELOG.md, or it's not applicable

Testing

How was this PR tested?

added several unit tests and tested manually

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 75.14%. Comparing base (1633dc0) to head (3611135).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7228      +/-   ##
==========================================
- Coverage   76.06%   75.14%   -0.92%     
==========================================
  Files         512      512              
  Lines       54343    54362      +19     
==========================================
- Hits        41337    40853     -484     
- Misses      12639    13145     +506     
+ Partials      367      364       -3     
Flag Coverage Δ
func 42.93% <83.33%> (-0.14%) ⬇️
system 63.22% <83.33%> (-1.17%) ⬇️
unit 57.67% <77.77%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
wandb/__init__.py 95.68% <100.00%> (ø)
wandb/env.py 78.41% <100.00%> (+0.23%) ⬆️
wandb/errors/__init__.py 94.11% <100.00%> (+0.36%) ⬆️
wandb/sdk/artifacts/artifact.py 93.24% <100.00%> (+0.03%) ⬆️
wandb/sdk/wandb_settings.py 93.96% <ø> (ø)
wandb/util.py 84.63% <100.00%> (-1.06%) ⬇️
wandb/sdk/wandb_require.py 95.45% <75.00%> (-2.05%) ⬇️
wandb/sdk/service/service.py 80.62% <71.42%> (-1.13%) ⬇️

... and 27 files with indirect coverage changes

@kptkin kptkin marked this pull request as ready for review April 4, 2024 01:39
@kptkin kptkin requested a review from a team as a code owner April 4, 2024 01:39
core/README.md Show resolved Hide resolved
@github-actions github-actions bot added cc-chore and removed cc-chore labels Apr 6, 2024
@github-actions github-actions bot added cc-chore and removed cc-chore labels Apr 6, 2024
@github-actions github-actions bot added cc-chore and removed cc-chore labels Apr 6, 2024
wandb/util.py Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the cc-chore label Apr 8, 2024
core/README.md Outdated Show resolved Hide resolved
tests/pytest_tests/unit_tests/test_util_wandb_core.py Outdated Show resolved Hide resolved
tests/pytest_tests/unit_tests/test_util_wandb_core.py Outdated Show resolved Hide resolved
wandb/util.py Show resolved Hide resolved
wandb/util.py Outdated Show resolved Hide resolved
@kptkin kptkin requested a review from a team as a code owner April 9, 2024 02:18
@kptkin kptkin requested a review from timoffex April 9, 2024 02:23
core/README.md Outdated Show resolved Hide resolved
wandb/sdk/artifacts/artifact.py Outdated Show resolved Hide resolved
wandb/sdk/service/service.py Show resolved Hide resolved
Copy link
Contributor

@ibindlish ibindlish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kptkin kptkin merged commit 371cb83 into main Apr 9, 2024
64 of 67 checks passed
@kptkin kptkin deleted the kpt/require_wandb_core branch April 9, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants