Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Tiny fix - use maps.Clone in filestream #7567

Merged

Conversation

timoffex
Copy link
Contributor

@timoffex timoffex commented May 5, 2024

No description provided.

Created using spr 1.3.5
@timoffex timoffex marked this pull request as ready for review May 5, 2024 09:51
@timoffex timoffex requested a review from a team as a code owner May 5, 2024 09:51
Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.74%. Comparing base (bbcc23d) to head (c2c58c1).

Additional details and impacted files

Impacted file tree graph

@@                                           Coverage Diff                                           @@
##           spr/timoffex/main.refactorcore-tiny-fix-use-mapsclone-in-filestream    #7567      +/-   ##
=======================================================================================================
+ Coverage                                                                75.67%   75.74%   +0.06%     
=======================================================================================================
  Files                                                                      501      501              
  Lines                                                                    53990    53989       -1     
=======================================================================================================
+ Hits                                                                     40859    40895      +36     
+ Misses                                                                   12720    12683      -37     
  Partials                                                                   411      411              
Flag Coverage Δ
func 41.15% <ø> (+0.14%) ⬆️
system 62.88% <100.00%> (+0.04%) ⬆️
unit 56.36% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/pkg/filestream/filestream.go 87.80% <100.00%> (-0.15%) ⬇️

... and 19 files with indirect coverage changes

Created using spr 1.3.5

[skip ci]
Created using spr 1.3.5
@timoffex timoffex changed the base branch from spr/timoffex/main.refactorcore-tiny-fix-use-mapsclone-in-filestream to main May 7, 2024 05:30
@timoffex timoffex merged commit ab50714 into main May 7, 2024
8 of 18 checks passed
@timoffex timoffex deleted the spr/timoffex/refactorcore-tiny-fix-use-mapsclone-in-filestream branch May 7, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants