chore(app): Adding small switch size per design #1667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,15 +2,18 @@ import * as Switch from '@radix-ui/react-switch'; | |||
| import React from 'react'; | |||
| import {twMerge} from 'tailwind-merge'; | |||
|
|
|||
| export type SwitchSize = 'small' | 'normal'; | |||
There was a problem hiding this comment.
Feels inconsistent for button sizes to be small/medium/large but switch sizes to be small/normal.
There was a problem hiding this comment.
A foolish consistency is the hobgoblin of little minds
There was a problem hiding this comment.
But honestly, I'm open to suggestions. I don't know that there are to be three variants on this so does making "normal" => "medium" feel right? I guess it's fine. Because worst case if there's a smaller one it's "x-small" | "small" | "medium"?
| <Switch.Thumb | ||
| className={twMerge( | ||
| 'h-[22px] w-[22px] rounded-full bg-white transition-transform duration-100 ease-out', | ||
| props.checked ? 'translate-x-20' : 'translate-x-0', | ||
| ' rounded-full bg-white transition-transform duration-100 ease-out', |
| size === 'small' ? 'h-[14px] w-[14px]' : 'h-[22px] w-[22px]', | ||
| size === 'small' && props.checked ? 'translate-x-12' : '', | ||
| size === 'normal' && props.checked ? 'translate-x-20' : '', | ||
| props.checked ? '' : 'translate-x-0', |
There was a problem hiding this comment.
Maybe !props.checked && 'translate-x-0' ?
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=63ba7292d5e7bb34372aa36c93ac7f34aea35473 |
jamie-rasmussen
approved these changes
May 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.figma.com/design/AbybbouWhi78Bp99M1FX2B/Workspace-settings-2.0-(May-2024)?node-id=2099-57562&t=edMw7C4Gx3saxonG-0