Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(weave): backend for deletion of calls #1673

Merged

Conversation

gtarpenning
Copy link
Member

@gtarpenning gtarpenning commented May 22, 2024

https://wandb.atlassian.net/browse/WB-18625
https://wandb.atlassian.net/browse/WB-18626
https://wandb.atlassian.net/browse/WB-18628

Adds:

  • calls_delete on the client
  • call.delete() on the call object
  • calls_delete() server method

depends on https://github.com/wandb/core/pull/21555 for wb_user_id to appear on deletion rows.

(old pr: #1655)

@gtarpenning gtarpenning changed the title chore(weave): backend deletion feat(weave): backend deletion May 22, 2024
@circle-job-mirror
Copy link

circle-job-mirror bot commented May 22, 2024

@gtarpenning gtarpenning marked this pull request as ready for review May 22, 2024 18:27
@gtarpenning gtarpenning requested a review from a team as a code owner May 22, 2024 18:27
Copy link
Collaborator

@tssweeney tssweeney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice Job!

@gtarpenning gtarpenning changed the title feat(weave): backend deletion feat(weave): backend for deletion of calls May 22, 2024
@gtarpenning gtarpenning merged commit 9f3253b into master May 22, 2024
25 checks passed
@gtarpenning gtarpenning deleted the griffin/deleted-at-backend-clean-final-final-no-going-back branch May 22, 2024 20:23
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants