chore(app): add hide text option to ModifiedDropdown #1688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=5cff6c56c0f6bf73fbefe1e033ded21519afcb35 |
mbarrramsey
changed the title
mbarrramsey
commented
May 29, 2024
| @@ -477,7 +484,7 @@ type OptionWithTooltipProps = { | |||
| text: string | null; | |||
| }; | |||
|
|
|||
| const OptionWithTooltip: React.FC<OptionWithTooltipProps> = ({text}) => { | |||
| export const OptionWithTooltip: React.FC<OptionWithTooltipProps> = ({text}) => { | |||
There was a problem hiding this comment.
To be used in https://github.com/wandb/core/pull/21754
mbarrramsey
commented
May 29, 2024
| props.text = hideText ? null : ( | ||
| <OptionWithTooltip text={opt.text as string} /> | ||
| ); | ||
| return props; |
There was a problem hiding this comment.
Adding the option to hide the text prop so that we can still search it's value, but only display the JSX label if we'd like
mbarrramsey
changed the title
onx2
approved these changes
May 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://wandb.atlassian.net/browse/WB-18777
Updates the
ModifiedDropdowncomponent to support hiding the input text prop so that we can display a JSX label as a dropdown option on its own. This will be used in the clone/ create report modal in an upcoming PR, https://github.com/wandb/core/pull/21754.Before:
After:
Screen.Recording.2024-05-29.at.12.48.58.PM.mov