chore(weave): add weave.finish #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=2efc932535932b9e4c660231e4eac5e886df860a |
tssweeney
reviewed
May 30, 2024
weave/api.py
Outdated
| # This is the stream-table backend. Disabling it in favor of the new | ||
| # trace-server backend. | ||
| # return _weave_init.init_wandb(project_name).client | ||
| # return _weave_init.init_trace_remote(project_name).client | ||
| return _weave_init.init_weave(project_name).client | ||
| _current_inited_client = _weave_init.init_weave(project_name) |
There was a problem hiding this comment.
non blocking comment: can you share why the api.py layer is responsible for handling the _current_inited_client state? It seems like this might want to be part of weave_init.py?
There was a problem hiding this comment.
no reasoning, it does make more sense to move that logic lower
tssweeney
reviewed
Jun 3, 2024
| @@ -104,15 +106,16 @@ def init_weave( | |||
| entity_name, project_name, remote_server, ensure_project_exists | |||
| ) | |||
|
|
|||
| init_client = InitializedClient(client) | |||
| global _current_inited_client | |||
| _current_inited_client = InitializedClient(client) | |||
There was a problem hiding this comment.
Should we be checking to see if _current_inited_client is already set? If it is, would that be something we should throw for?
tssweeney
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Looks good - a few things (#1 is probably the main thing to consider):
- Can you add a test like the one in your PR description's screenshot
- See comment in
weave/weave_init.py - The stuff around
because OpenAI calls are not logged in local mode currentlymight not be true anymore - it might be a nice followup to move these two calls to the correct locations.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internal jira
https://wandb.atlassian.net/browse/WB-18715
You can now stop tracing stuff with weave.finish()
Something like this now only traces the middle call