fix(app): Removing infinite loop on modified dropdown render #1697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=08831672fa5410d3c646cae05be2a98320c8dbe3 |
onx2
reviewed
May 30, 2024
| } | ||
| const isOverflow = | ||
| optionRef.current.scrollWidth > optionRef.current.clientWidth; | ||
| if (optionRef.current && isOverflow !== showTooltip) { |
There was a problem hiding this comment.
is optionRef.current && required here now that you are checking above?
onx2
approved these changes
May 30, 2024
onx2
reviewed
May 30, 2024
Comment on lines
+490
to
+491
| if (isOverflow !== showTooltip) { | ||
| setShowTooltip(isOverflow); |
There was a problem hiding this comment.
could this just be setShowTooltip(isOverflow);? React shouldn't cause an update if it ends up the same boolean value 🤔
There was a problem hiding this comment.
I don't have a great answer here. Why this is infinite looping is not exactly known to me. I just know this fixes it as experienced.
There was a problem hiding this comment.
oh wait duh 😂 , that was the previous code. I wonder if this is because of the ref
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wandb.atlassian.net/browse/WB-19077
Effect updating state causing infinite render. Unsure as to the deeper root cause but this fixes the error.