chore(weave): Add attributes to Call object and allow explicit root

weave/tests/test_client_trace.py

@@ -74,6 +74,7 @@ def my_op(a: int) -> int:
         exception=None,
         output=6,
         summary={},
+        attributes={},
     )
 
 

weave/tests/test_weave_client.py

@@ -211,6 +211,7 @@ def test_call_create(client):
         exception=None,
         summary={},
         _children=[],
+        attributes={},
     )
     assert dataclasses.asdict(result._val) == dataclasses.asdict(expected)
 
@@ -228,6 +229,7 @@ def test_calls_query(client):
         parent_id=None,
         inputs={"a": 5, "b": 10},
         id=call0.id,
+        attributes={},
     )
     assert result[1] == weave_client.Call(
         op_name="weave:///shawn/test-project/op/x:tzUhDyzVm5bqQsuqh5RT4axEXSosyLIYZn9zbRyenaw",
@@ -236,6 +238,7 @@ def test_calls_query(client):
         parent_id=call0.id,
         inputs={"a": 6, "b": 11},
         id=call1.id,
+        attributes={},
     )
     client.finish_call(call2, None)
     client.finish_call(call1, None)

weave/weave_client.py

@@ -144,6 +144,7 @@ class Call:
     exception: Optional[str] = None
     summary: Optional[dict] = None
     display_name: Optional[str] = None
+    attributes: Optional[dict] = None
     # These are the live children during logging
     _children: list["Call"] = dataclasses.field(default_factory=list)
 
@@ -244,6 +245,7 @@ def make_client_call(
         output=output,
         summary=server_call.summary,
         display_name=server_call.display_name,
+        attributes=server_call.attributes,
     )
     if call.id is None:
         raise ValueError("Call ID is None")
@@ -457,9 +459,21 @@ def create_call(
         op: Union[str, Op],
         parent: Optional[Call],
         inputs: dict,
-        attributes: dict = {},
+        attributes: Optional[dict] = None,
         display_name: Optional[str] = None,
+        *,
+        _use_stack: bool = True,
     ) -> Call:
+        """Create, log, and push a call onto the runtime stack.
+
+        Args:
+            op (Union[str, Op]): The operation to log.
+            parent (Optional[Call]): The parent call. If parent is not provided, the current run is used as the parent.
+            inputs (dict): The inputs to the operation.
+            display_name (Optional[str], optional): The display name for the call. Defaults to None.
+            attributes (Optional[dict], optional): The attributes for the call. Defaults to None.
+            _use_stack (bool, optional): Whether to push the call onto the runtime stack. Defaults to True.
+        """
         if isinstance(op, str):
             if op not in self._anonymous_ops:
                 self._anonymous_ops[op] = _build_anonymous_op(op)
@@ -474,7 +488,7 @@ def create_call(
         inputs_with_refs = map_to_refs(inputs)
         call_id = generate_id()
 
-        if parent is None:
+        if parent is None and _use_stack:
             parent = run_context.get_current_run()
 
         if parent:
@@ -483,6 +497,10 @@ def create_call(
         else:
             trace_id = generate_id()
             parent_id = None
+
+        if attributes is None:
+            attributes = {}
+
         call = Call(
             op_name=op_str,
             project_id=self._project_id(),
@@ -491,6 +509,7 @@ def create_call(
             id=call_id,
             inputs=inputs_with_refs,
             display_name=display_name,
+            attributes=attributes,
         )
         if parent is not None:
             parent._children.append(call)
@@ -510,7 +529,10 @@ def create_call(
             wb_run_id=current_wb_run_id,
         )
         self.server.call_start(CallStartReq(start=start))
-        run_context.push_call(call)
+
+        if _use_stack:
+            run_context.push_call(call)
+
         return call
 
     @trace_sentry.global_trace_sentry.watch()