Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: copyable call ID #1753

Merged
merged 1 commit into from
Jun 11, 2024
Merged

feat: copyable call ID #1753

merged 1 commit into from
Jun 11, 2024

Conversation

jamie-rasmussen
Copy link
Contributor

Internal Jira: https://wandb.atlassian.net/browse/WB-19230
Internal Figma: https://www.figma.com/design/mufhcDVpsRg9HJrLM61PCN/Weave-(May2024)?node-id=561-83013

  • Replaces existing "CallId" component with a slightly more generic one that can be used with other UUIDs (like upcoming feedback UUIDs).
  • Adds a version of the component that can copy to clipboard on click, with an updated tooltip display.

Hover UI - same as current except will have hand cursor
Screenshot 2024-06-11 at 5 36 51 PM

After click - tooltip updated
Screenshot 2024-06-11 at 5 36 53 PM

@Yangyi-wandb FYI.

@circle-job-mirror
Copy link

circle-job-mirror bot commented Jun 11, 2024

@jamie-rasmussen jamie-rasmussen marked this pull request as ready for review June 11, 2024 23:06
@jamie-rasmussen jamie-rasmussen requested a review from a team as a code owner June 11, 2024 23:06
@jamie-rasmussen jamie-rasmussen merged commit 1c66c8e into master Jun 11, 2024
24 checks passed
@jamie-rasmussen jamie-rasmussen deleted the jamie/copyable-id branch June 11, 2024 23:20
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants