chore(weave): Simplify TraceServerInterface definition and fix inheritance #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=4745cbb70f1d6be5b5f73872b64d53e0c0607186 |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=5ac68fd6fac62b84fed9ce9d87e8874446a56e0f |
gtarpenning
approved these changes
Jun 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced a violation of inheritance rules with
TraceServerInterfacePostAuth. We added this because the interface definition for the HTTP server differs slightly from that of the internal trace storage layers (namely the inclusion of wb_user_id which is populated by the server - and therefore not required).This was problematic for a few reasons:
RemoteHTTPTraceServerwas no longer compatible with the other servers. This is not a good place to be in.To remedy this, I:
TraceServerInterfacePostAuth