Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Action to check if mocks are synced with wandb/client:master #39

Closed
wants to merge 6 commits into from

Conversation

dmitryduev
Copy link
Member

@dmitryduev dmitryduev commented Jan 26, 2022

Tested this by screwing up mock_server.py -- it works (see 0c6d684).

@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #39 (75ce1ad) into main (f9a0643) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #39   +/-   ##
=======================================
  Coverage   11.42%   11.42%           
=======================================
  Files           7        7           
  Lines        1435     1435           
=======================================
  Hits          164      164           
  Misses       1271     1271           
Flag Coverage Δ
unittest 11.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9a0643...75ce1ad. Read the comment docs.

@kptkin
Copy link
Contributor

kptkin commented Jan 26, 2022

Ah this is a nice addition, I wonder if we could have something that automatically syncs them.
Or some way not to maintain 2 copies

@dmitryduev
Copy link
Member Author

@kptkin ah, good thinking! like downloading/checking sync as a part of the plugin setup process?

@dmitryduev
Copy link
Member Author

dmitryduev commented Jan 26, 2022

Idea: How about a GH action in wandb/client that opens a PR here (prob don't want to just push to main) if those files are touched on master? @raubitsj?

@dmitryduev
Copy link
Member Author

@dmitryduev
Copy link
Member Author

Closing in favor of wandb/wandb#3189 -- it seems to make more sense to have this check there.

@dmitryduev dmitryduev closed this Jan 28, 2022
@dmitryduev dmitryduev deleted the check-mocks branch February 14, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants