Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new mock server fields for server hints #65

Merged
merged 7 commits into from
Jul 7, 2022
Merged

add new mock server fields for server hints #65

merged 7 commits into from
Jul 7, 2022

Conversation

kptkin
Copy link
Contributor

@kptkin kptkin commented May 27, 2022

Sync with the changes in this PR: wandb/wandb#3706

@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #65 (2a3f468) into main (0768156) will decrease coverage by 0.04%.
The diff coverage is 12.50%.

@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   10.33%   10.29%   -0.05%     
==========================================
  Files           7        7              
  Lines        1635     1642       +7     
==========================================
  Hits          169      169              
- Misses       1466     1473       +7     
Flag Coverage Δ
unittest 10.29% <12.50%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/yea_wandb/mock_server.py 0.00% <0.00%> (ø)
src/yea_wandb/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0768156...2a3f468. Read the comment docs.

@kptkin kptkin requested a review from raubitsj June 28, 2022 06:24
@kptkin kptkin changed the title add new introspection add new mock server fields for server hints Jun 28, 2022
@kptkin kptkin requested a review from dmitryduev July 7, 2022 04:02
@kptkin
Copy link
Contributor Author

kptkin commented Jul 7, 2022

Pre req to merge this one: wandb/wandb#3706

Copy link
Member

@dmitryduev dmitryduev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DSofA 👍🏻 (Dima's Seal of Approval)

@kptkin kptkin merged commit ce77319 into main Jul 7, 2022
@kptkin kptkin deleted the WB-9827 branch July 7, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants