Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix run queue item ids to string type #74

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Conversation

KyleGoyette
Copy link
Contributor

@KyleGoyette KyleGoyette commented Jul 7, 2022

There were some issues from returning ints as the id type for run queue items. Since we expect a string, this just corrects all of them to strings.

@KyleGoyette KyleGoyette changed the title fix run queue item ids to string type Fix run queue item ids to string type Jul 7, 2022
@KyleGoyette KyleGoyette requested a review from raubitsj July 7, 2022 21:57
@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #74 (aaa12cf) into main (ce77319) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage   10.29%   10.29%           
=======================================
  Files           7        7           
  Lines        1642     1642           
=======================================
  Hits          169      169           
  Misses       1473     1473           
Flag Coverage Δ
unittest 10.29% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/yea_wandb/mock_server.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce77319...aaa12cf. Read the comment docs.

@raubitsj raubitsj merged commit 5e5078f into main Jul 8, 2022
@raubitsj raubitsj deleted the fix/runqueueitemid branch July 8, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants