Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin flask.. new release is causing dependency issues and flake for imports5 #90

Closed
wants to merge 3 commits into from

Conversation

raubitsj
Copy link
Member

@raubitsj raubitsj commented Aug 4, 2022

History:
https://pypi.org/project/Flask/2.2.1/#history

actually not sure the dependency is coming from yea-wandb.. but it is likely the culprit

flask 2.2.1 requires Werkzeug>=2.2.0, but you have werkzeug 2.0.2 which is incompatible.

Error:

File "/mnt/ramdisk/.tox/func-s_imports5-py37/lib/python3.7/site-packages/flask/__init__.py", line 4, in <module>
    from . import json as json
  File "/mnt/ramdisk/.tox/func-s_imports5-py37/lib/python3.7/site-packages/flask/json/__init__.py", line 8, in <module>
    from ..globals import current_app
  File "/mnt/ramdisk/.tox/func-s_imports5-py37/lib/python3.7/site-packages/flask/globals.py", line 57, in <module>
    _cv_app, unbound_message=_no_app_msg
TypeError: __init__() got an unexpected keyword argument 'unbound_message'

@raubitsj raubitsj requested a review from a team August 4, 2022 21:42
@raubitsj raubitsj changed the title Pin flask.. a change was flake for imports5 Pin flask.. new release is causing dependency issues and flake for imports5 Aug 4, 2022
@dmitryduev
Copy link
Member

@raubitsj this is the solution we came up:
https://github.com/wandb/wandb/blob/13a4ab6c24410c70ca0df0e7781c72e018504801/tests/functional_tests/t0_main/imports/05-batch5.py#L14
works great and no yea-wandb releases are necessary

Copy link
Member

@dmitryduev dmitryduev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment, this might not be necessary.

@raubitsj
Copy link
Member Author

dropped as a better workaround was provided

@raubitsj raubitsj closed this Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants