Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pushstream.js Utils.isCrossDomainUrl bugfix for IE #170

Closed
wants to merge 1 commit into from
Closed

pushstream.js Utils.isCrossDomainUrl bugfix for IE #170

wants to merge 1 commit into from

Conversation

arusakov
Copy link
Contributor

Hi, wandenberg

Current code for parsing url:

var parser = document.createElement('a');
parser.href = url; 

If url does not contains port, for example "http://test.com", IE behaves differently then other browsers.

Browser location.port parser.port
Chrome 39 '' ''
Firefox 34 '' ''
Opera 12.16 '' ''
IE9 '' '80'
IE 11 '' '80'

normalizePort() fix that for http and https protocols.

@wandenberg
Copy link
Owner

Merged with small changes. Thanks

@wandenberg wandenberg closed this Dec 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants