Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility and SEO improvements #96

Closed
wants to merge 2 commits into from
Closed

Accessibility and SEO improvements #96

wants to merge 2 commits into from

Conversation

jcabak
Copy link
Contributor

@jcabak jcabak commented Apr 16, 2021

  • All links have title attribute and are accessible to everyone

@wangchucheng
Copy link
Owner

Thanks for this PR! Accessibility is of vital importance.

However, when I search for when to use the title attribute, many posts said that this attribute should not be the same of the content, as it will be meaningless. I'm not an expert of accessibility or seo, so I want to make sure of it. But I think it is necessary to add the title attribute to those icon links at least.

@jcabak jcabak closed this Apr 21, 2021
@jcabak jcabak deleted the a11yseo branch April 21, 2021 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jcabak @wangchucheng