Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[System] Check for null add empty only condition #786

Merged
merged 4 commits into from
Jun 23, 2023
Merged

[System] Check for null add empty only condition #786

merged 4 commits into from
Jun 23, 2023

Conversation

wangkanai
Copy link
Owner

The check for null is now getting more complicated with each new edge case during my investigative journey. I find that we should have checking just for empty string. Also adding to this, an ArgumentEmptyException to go along with the check.

Then come the point of the instance activator of creating exception instance when the condition is found to be throw.

@wangkanai
Copy link
Owner Author

I feel now that the Check is getting very organized, but in the meantime, the class is gaining lines of code up to 500. if this trend continues on this path. I will need to consider refactor them into more manageable smaller class.

@wangkanai
Copy link
Owner Author

@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

85.7% 85.7% Coverage
0.0% 0.0% Duplication

@wangkanai wangkanai merged commit e5772f9 into main Jun 23, 2023
3 checks passed
@wangkanai wangkanai deleted the exception branch June 23, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant