Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Webmaster] Review and refactor webmaster #813

Merged
merged 11 commits into from
Jul 3, 2023
Merged

[Webmaster] Review and refactor webmaster #813

merged 11 commits into from
Jul 3, 2023

Conversation

wangkanai
Copy link
Owner

  • Review the code functions and responsibilities
  • Refactor the code with SOLID principle
  • Add unit tests for better code coverage and quality insurance

- Review the code functions and responsibilities
- Refactor the code with SOLID principle
- Add unit tests for better code coverage and quality insurance
@wangkanai wangkanai self-assigned this Jul 2, 2023
@wangkanai wangkanai added this to the 7.0 milestone Jul 2, 2023
Copy link
Owner Author

@wangkanai wangkanai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now verified

@sonarcloud
Copy link

sonarcloud bot commented Jul 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

79.3% 79.3% Coverage
0.0% 0.0% Duplication

@wangkanai wangkanai merged commit a2aa7da into main Jul 3, 2023
3 checks passed
@wangkanai wangkanai deleted the webmaster branch July 3, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant